Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for edit permission when showing store credit edit link #3843

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Check for edit permission when showing store credit edit link #3843

merged 1 commit into from
Nov 17, 2020

Conversation

spaghetticode
Copy link
Member

Description

Checking for show makes the edit link visible also to users that cannot edit store credits. This is corrected by checking for the edit permission.

Checklist:

@spaghetticode
Check for edit permission when showing store credit edit link
682e939 
Checking for `show` makes the edit link visible also to users that
cannot edit store credits. This is corrected by checking for the
`edit` permission.
@spaghetticode spaghetticode added the changelog:solidus_backend Changes to the solidus_backend gem label Nov 16, 2020
@spaghetticode spaghetticode self-assigned this Nov 16, 2020
kennyadsl
kennyadsl approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kennyadsl kennyadsl added this to the 3.0.0 milestone Nov 17, 2020
@kennyadsl kennyadsl merged commit 8679eea into solidusio:master Nov 17, 2020
@kennyadsl kennyadsl deleted the spaghetticode/permission-fix branch November 17, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@spaghetticode spaghetticode

Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@spaghetticode @kennyadsl @jarednorman